Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line redraw #6429

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Fix line redraw #6429

merged 3 commits into from
Jan 9, 2023

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 8, 2023

Fixes #6407.
@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Jan 8, 2023
alexcjohnson
alexcjohnson approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, clean fix and excellent test! 💃 Just needs a changelog entry.

@archmoj archmoj merged commit a709417 into master Jan 9, 2023
@archmoj archmoj deleted the fix6407-line-redraw branch January 9, 2023 14:43
@kmcgrady kmcgrady mentioned this pull request Jan 24, 2023
Closed
5 tasks
This was referenced Feb 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Ghost traces after zooming/panning when data has gaps (null)
2 participants
@archmoj @alexcjohnson