Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding automargin support to plot titles #6428

Merged
merged 63 commits into from
Mar 15, 2023
Merged

Adding automargin support to plot titles #6428

merged 63 commits into from
Mar 15, 2023

Commits on Jan 6, 2023

  1. Initial pass with hard-coded automargin params

    @hannahker
    hannahker committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    68c6165 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Remove role from schema

    @hannahker
    hannahker committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    ad6eb00 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Merge branch 'master' into automargin-title

    @hannahker
    hannahker committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    0826ddd View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Move automargin call

    @hannahker
    hannahker committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    45d9cbf View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. lint

    @archmoj @hannahker
    archmoj authored and hannahker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c6e31be View commit details
    Browse the repository at this point in the history

  2. rename mock and generate baseline

    @archmoj @hannahker
    archmoj authored and hannahker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f46014f View commit details
    Browse the repository at this point in the history

  3. update pie_automargin-margin0 baseline

    @archmoj @hannahker
    archmoj authored and hannahker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    587dfcb View commit details
    Browse the repository at this point in the history

  4. adjust pie test

    @archmoj @hannahker
    archmoj authored and hannahker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    3dae109 View commit details
    Browse the repository at this point in the history

  5. Simplify automargin title to use existing functions

    @hannahker
    hannahker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    61487a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Account for padding around title

    @hannahker
    hannahker committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    8679e7d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Adjust mock to yref=paper

    @hannahker
    hannahker committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    e8e49a5 View commit details
    Browse the repository at this point in the history

  2. Temp fix for yref=paper

    @hannahker
    hannahker committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2b59e2c View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Merge branch 'master' into automargin-title

    @hannahker
    hannahker committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    5e4ab42 View commit details
    Browse the repository at this point in the history

  2. Improve handling for paper ref and setting defaults

    @hannahker
    hannahker committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    4bb109e View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @hannahker
    hannahker committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    7ce1234 View commit details
    Browse the repository at this point in the history

  4. Add jasmine test

    @hannahker
    hannahker committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b274642 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Simplify mock

    @hannahker
    hannahker committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    cc15ff6 View commit details
    Browse the repository at this point in the history

  2. Fix test formatting

    @hannahker
    hannahker committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    938d52d View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Add simple implementation for container behaviour

    @hannahker
    hannahker committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    75636e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Apply review comments

    @hannahker
    hannahker committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    b7e3295 View commit details
    Browse the repository at this point in the history

  2. Add more tests for yref=container

    @hannahker
    hannahker committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    04f8825 View commit details
    Browse the repository at this point in the history

  3. Ajust default setting

    @hannahker
    hannahker committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    ad202d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Remove outdated mock

    @hannahker
    hannahker committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    9611672 View commit details
    Browse the repository at this point in the history

  2. Update mock baselines

    @hannahker
    hannahker committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    c4d1076 View commit details
    Browse the repository at this point in the history

  3. Fix syntax

    @hannahker
    hannahker committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    21a9e59 View commit details
    Browse the repository at this point in the history

  4. Remove f from test

    @hannahker
    hannahker committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    78cecff View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Set yanchor properly when title is at bottom

    @hannahker
    hannahker committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    fd111d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Make defaults setting logic more readable

    @hannahker
    hannahker committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    2a47c00 View commit details
    Browse the repository at this point in the history

  2. Add reservedMargins logic

    @hannahker
    hannahker committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    52b37c0 View commit details
    Browse the repository at this point in the history

  3. Revert some changes to test

    @hannahker
    hannahker committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4322c7b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Fix bugs

    @hannahker
    hannahker committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    73ccaf4 View commit details
    Browse the repository at this point in the history

  2. Fix more bugs from redraw

    @hannahker
    hannahker committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a3462d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Apply review comments

    @hannahker
    hannahker committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    33bbbef View commit details
    Browse the repository at this point in the history

  2. Add jasmine test for interaction with x axis

    @hannahker
    hannahker committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9af5cbd View commit details
    Browse the repository at this point in the history

  3. Push pie test fix

    @hannahker
    hannahker committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    67cf8da View commit details
    Browse the repository at this point in the history

  4. Fix scooting behaviour to account for reserved margin space

    @hannahker
    hannahker committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    16c0bcf View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Check if automargin is necessary before applying

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    17c3244 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c014702 View commit details
    Browse the repository at this point in the history

  3. Warn when title.y is being set to 1

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e59b18f View commit details
    Browse the repository at this point in the history

  4. Fix syntax and another mock update

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ddaf013 View commit details
    Browse the repository at this point in the history

  5. Apply review comments

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    de7ca48 View commit details
    Browse the repository at this point in the history

  6. Calc bb for title

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e77126c View commit details
    Browse the repository at this point in the history

  7. Fix warning log

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    26ca553 View commit details
    Browse the repository at this point in the history

  8. Update parameter description

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e5e8a2a View commit details
    Browse the repository at this point in the history

  9. Reposition properly

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d70fb46 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into automargin-title

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    616057f View commit details
    Browse the repository at this point in the history

  11. Only reposition title if necessary

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3523406 View commit details
    Browse the repository at this point in the history

  12. Fix syntax

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    90bd374 View commit details
    Browse the repository at this point in the history

  13. Fix tests

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    158791f View commit details
    Browse the repository at this point in the history

  14. Merge branch 'automargin-title-dev' into automargin-title

    @hannahker
    hannahker committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c4e706e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Adjust tests to match rendering in CI

    @hannahker
    hannahker committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    087c162 View commit details
    Browse the repository at this point in the history

  2. Update mocks

    @hannahker
    hannahker committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c4d75d4 View commit details
    Browse the repository at this point in the history

  3. Add review comment

    @hannahker
    hannahker committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a257836 View commit details
    Browse the repository at this point in the history

  4. Update mock baselines

    @hannahker
    hannahker committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    662628e View commit details
    Browse the repository at this point in the history

  5. Adjust titles on mocks

    @hannahker
    hannahker committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e4b5f29 View commit details
    Browse the repository at this point in the history

  6. Update baselines

    @hannahker
    hannahker committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3dcaab8 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Add milti-line title

    @hannahker
    hannahker committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2a0011a View commit details
    Browse the repository at this point in the history

  2. Update baselines

    @hannahker
    hannahker committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    a8185f4 View commit details
    Browse the repository at this point in the history

  3. Revert dy change

    @hannahker
    hannahker committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0c0e47e View commit details
    Browse the repository at this point in the history

  4. move smart default for title.y and title.yanchor to supply defaults

    @archmoj @hannahker
    archmoj authored and hannahker committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7f89c73 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Adjust dy to fix offset

    @hannahker
    hannahker committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    132c57b View commit details
    Browse the repository at this point in the history

  2. baseline update

    @archmoj
    archmoj committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    7d4e352 View commit details
    Browse the repository at this point in the history

  3. Add draftlog

    @hannahker
    hannahker committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ad7c6f0 View commit details
    Browse the repository at this point in the history