Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Treemap Trace: remove extra if statement in default.js #5565

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Refactor Treemap Trace: remove extra if statement in default.js #5565

merged 1 commit into from
Mar 25, 2021

Conversation

mtwichan
Copy link
Contributor

@mtwichan mtwichan commented Mar 24, 2021 •
edited by archmoj
Loading

PR to remove the extra if statement I found when working on the icicle plot.

More detail can be found here: #5546 (comment)

@mtwichan mtwichan requested a review from archmoj March 24, 2021 21:12
@mtwichan mtwichan mentioned this pull request Mar 24, 2021
Merged
17 tasks
@archmoj
Copy link
Contributor

archmoj commented Mar 25, 2021

Thanks!
LGTM
💃

@archmoj archmoj merged commit 535ab84 into master Mar 25, 2021
@archmoj archmoj deleted the matthew-treemap-refactor-fix branch March 25, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archmoj archmoj Awaiting requested review from archmoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtwichan @archmoj