Fixup categoryorder for missing values in cartesian traces

[archmoj]

Fixes #5267.

@plotly/plotly_js
cc: @cldougl

[nicolaskruchten]

@antoinerg can you take a look here as well plz, given that you did the original implementation here?

The original reports were strangely hard to reproduce: #5267 ... does your fix sort of suggest why this might be machine/browser/environment-dependent, @archmoj ?

[archmoj]

The original reports were strangely hard to reproduce: #5267 ... does your fix sort of suggest why this might be machine/browser/environment-dependent, @archmoj ?

Possibly related to the fact that the width and height were not set on the mock you were testing...

[nicolaskruchten]

Ah that's an interesting possibility... But why does the category order depend on the width?!?

[archmoj]

Ah that's an interesting possibility... But why does the category order depend on the width?!?

I've not noticed this bug on different browsers.
Anyway the width may impact the bin size for histograms maybe?

[nicolaskruchten]

This is a categorical histogram so there is no bin size :)

[antoinerg]

@archmoj can you point me where in the code the existing behavior was changed.

[archmoj]

@nicolaskruchten
Testing this mock on different OS+browsers leads to the identical error as far as I could test :)

[antoinerg]

Thanks @archmoj for the nice code cleanup and bug fix! LGTM 💃