Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gl-plot2d & gl-plot3d and drop ndarray-fill #4929

Merged
merged 2 commits into from
Jun 18, 2020
Merged

bump gl-plot2d & gl-plot3d and drop ndarray-fill #4929

merged 2 commits into from
Jun 18, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 18, 2020

First step to reduce audit warnings i.e. not using cwise in some modules namely gl-vis/gl-select-static#4.

@plotly/plotly_js
cc: #4796

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a bonus the code is now readable without having to guess at what ndarray-fill is doing! Speed is presumably the same or marginally better this way. 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants