Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev install acorn, espree and mkdirp modules #4800

Merged
merged 4 commits into from
May 1, 2020
Merged

Dev install acorn, espree and mkdirp modules #4800

merged 4 commits into from
May 1, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 1, 2020

In respect to ##4796
This PR helps reduce the number of warnings for acornusing regl.

Before:
before

After:
after

See commit cabe146 for details.

Also to mention, the audit files were created using the commands below:

npm audit --json > audit.json
npm audit | sed -r "s/\x1B\[([0-9]{1,3}(;[0-9]{1,2})?)?[mGK]//g" > audit.txt

@plotly/plotly_js

@archmoj archmoj added this to the v1.54.1 milestone May 1, 2020
@archmoj archmoj requested a review from alexcjohnson May 1, 2020 16:31
alexcjohnson
alexcjohnson reviewed May 1, 2020
View reviewed changes
@archmoj
Copy link
Contributor Author

archmoj commented May 1, 2020

Also dev-installed espree v6.2.1 and mkdirp v1.0.4 in this PR to reduce the warnings to:

newAfter

@archmoj archmoj changed the title Dev install acorn Dev install acorn, espree and mkdirp modules May 1, 2020
alexcjohnson
alexcjohnson approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 3b1ff46 into master May 1, 2020
@archmoj archmoj deleted the dev-install-acorn branch May 1, 2020 18:29
@archmoj archmoj mentioned this pull request May 4, 2020
Merged
@archmoj archmoj mentioned this pull request Aug 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.54.1
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson