Use URL.createObjectURL during Plotly.downloadImage #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to workaround Chrome URL length limit (#3771) and probably (not tested) have a perf boost. N.B. createObjectURL expects Blob object which itself expect data string w/o data:image prefix, so use imageDataOnly in the Plotly.toImage call
- so that when we can fallback to window.webkitURL if window.URL isn't defined
- which speeds up things for loooong SVG strings - must (still) use encodeSVG in Safari and IE9
|
Looks good to me! Thanks for the improvement 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to not hit the 2MB URL-length limit in Chrome - which resolves #3771 - and improve
downloadImageperformance.before: https://codepen.io/anon/pen/WWZBOB
after: https://codepen.io/etpinard/pen/MMGGVW (click to "Download plot as a png" modebar button)
All-format playground: https://codepen.io/etpinard/pen/QXraeW
@plotly/plotly_js