Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hovermode default logic for stacked scatter traces #3646

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

etpinard
Copy link
Contributor

fixes #3619 - so that by default graphs with horizontally stacked scatter traces get the correct hovermode: 'y' default (that is, until #778 in v2 😏 )

cc @plotly/plotly_js note that orientation is only coerced into fullData once per stack. Unnecessary keys are removed here.

@etpinard etpinard added bug something broken status: reviewable labels Mar 18, 2019
@antoinerg
Copy link
Contributor

@antoinerg
Copy link
Contributor

antoinerg commented Mar 18, 2019

Thank you @etpinard for improving the default hovermode for horizontally stacked scatter traces and for the clear test!

💃

@etpinard etpinard merged commit 448cb14 into master Mar 18, 2019
@etpinard etpinard deleted the isHoriz-fix-for-stacked-scatter-traces branch March 18, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare Mode Bar button is for 'x' axis not 'y'axis when all Scatter Chart traces are Horizontal
2 participants