Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legend: enable selection of a trace by clicking its symbol #3635

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

antoinerg
Copy link
Contributor

Fixes #3627 by drawing legendtoggle last to make it unobstructed.

@antoinerg antoinerg added bug something broken status: reviewable labels Mar 13, 2019
@antoinerg
Copy link
Contributor Author

Codepen before (legend symbols are unclickable) https://codepen.io/antoinerg/pen/rRpoxL
Codepen after (legend symbols are clickable): https://codepen.io/antoinerg/pen/pYpqgo

@antoinerg antoinerg added the regression this used to work label Mar 18, 2019
@etpinard
Copy link
Contributor

Nice catch. This was working fine in 1.43.2: https://codepen.io/etpinard/pen/BbVvbx

@etpinard
Copy link
Contributor

Yeah my #3435 messed this up.

Thanks for the fix and test @antoinerg !

💃

@antoinerg antoinerg merged commit fc236e2 into master Mar 18, 2019
@antoinerg antoinerg deleted the fix-legend-3627 branch March 18, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants