Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set camera mode to turntable when up.z is zero #3465

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Do not set camera mode to turntable when up.z is zero #3465

merged 2 commits into from
Jan 23, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 23, 2019

Fixes #3425 by not defaulting to turntable when camera.up.z is set to zero.
@etpinard

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Jan 23, 2019
@etpinard
Copy link
Contributor

Thank you! 💃

@archmoj
Copy link
Contributor Author

archmoj commented Jan 23, 2019

@etpinard Thanks for the review.

@archmoj archmoj merged commit 1aa6c85 into master Jan 23, 2019
@archmoj archmoj deleted the fix3425-camera-change branch January 23, 2019 23:12
@etpinard
Copy link
Contributor

@archmoj This PR made

image

fail. Would mind taking a 👁️ at this?

Running

npm run test-jasmine -- plot_api_react

should be enough to replicate the failure.

@archmoj
Copy link
Contributor Author

archmoj commented Jan 24, 2019 •
edited
Loading

OK. I am working on it.

@archmoj
Copy link
Contributor Author

archmoj commented Jan 24, 2019

To pass this test this line should not have a z value equal to zero:

plotly.js/test/jasmine/tests/plot_api_react_test.js

Line 220 in ee0a6cc

layout.scene.camera = {up: {x: 1, y: -1, z: 0}};

We may try layout.scene.camera = {up: {x: 1, y: 0, z: -1}}; instead.

@archmoj archmoj mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @etpinard