Apply derequire to generated bundles #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite require calls in the generated bundles so that Browserify is able to consume the bundles when bundling new bundles. Solves issue #2902.
etpinard
reviewed
Aug 15, 2018
| @@ -80,3 +84,14 @@ function logger(pathToOutput) { | |||
| var log = 'ok ' + path.basename(pathToOutput); | |||
| console.log(log); | |||
| } | |||
|
|
|||
| function applyDerequire() { | |||
There was a problem hiding this comment.
Ah nice, you turned the plugin into a transforms for speed. Love it!
|
Thanks very much @m90 🎉 🍻 💃 I can confirm that bundling using browserify and webpack@3 the dist bundles from Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite require calls in the generated bundles so that Browserify is able
to consume the bundles when bundling new bundles. Solves issue #2902.
I can successfully use the bundle this builds in Browserify as well as Webpack (CRA). That being said I am not a Webpack Pro, so if someone else could double check this it'd be much appreciated.