Add doubleclick events #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on dragbox double clicks and select/lasso double clicks
- so that Plots is consistent from suite to suite.
- so that test Chrome and FF can agree
| var Plots = Plotly.Plots; | ||
|
|
||
| beforeEach(function() { | ||
| this.modulesKeys = Object.keys(Plots.modules); |
There was a problem hiding this comment.
Can we avoid using this here?
There was a problem hiding this comment.
Sure.
You're not a fan of the jasmine this ?
There was a problem hiding this comment.
Actually on second look, I'm ok with that. Didn't know that it was jasmine convention and that the this is cleared between specs.
- double click on a data pt now (1) fires a click event, (2) fires a double click event and (3) fires another click event, with the same event data - double clicking not on a data pt fires a double click event with null event data
- to not introduce more complexity into our set of event data
|
Looks good. Nice tests too. Seems like 💃 |
| @@ -171,6 +171,8 @@ module.exports = function prepSelect(e, startX, startY, dragOptions, mode) { | |||
| searchInfo = searchTraces[i]; | |||
| searchInfo.selectPoints(searchInfo, false); | |||
| } | |||
|
|
|||
| gd.emit('plotly_deselect', null); | |||
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @cpsievert in plotly/plotly.R#416 .
This PR also introduces jasmine tests for select and lasso event data.
Part of #145