Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2262 - Selection displayed on incorrect subplot #2263

Closed
wants to merge 2 commits into from

Conversation

paulsputer
Copy link

Transform now set on updates as per path.

@alexcjohnson
Copy link
Collaborator

Nice find! For perf though, I suspect this just needs to be moved outside the enter() where we had it originally, to just outlines.attr('transform', ...) like you added, but doesn't need to be called in moveFn (which is called repeatedly on mousemove).

Also we may want to leave #2262 open until we figure out what we want to do with #2262 (comment)

@paulsputer
Copy link
Author

I see yea, also looks like we need to reset the path to path0 otherwise we get a draw error until a new path is created.

+ displays selection box on relevant subplot
+ removes selection box and selected points from other subplots
@paulsputer
Copy link
Author

Closing PR as it appears to have been fixed in ebaf705

@paulsputer paulsputer closed this Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants