Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if an invalid scale is passed #1736

Closed
wants to merge 1 commit into from

Conversation

mdamien
Copy link

@mdamien mdamien commented May 26, 2017

When an invalid scale is passed, it's silently ignored if it's invalid. This makes it painful to debug (did I use the right parameter ? does this chart support colorscales ?). So I propose to add a warning for invalid scales.

Of course, people still have to do Plotly.setPlotConfig({logging: true});

@etpinard
Copy link
Contributor

Thanks very much for the PR!

Personally, I would prefer making sure the very-undocumented Plotly.validate catches all invalid colorscales which should already be the case.

@alexcjohnson
Copy link
Collaborator

@etpinard I seem to recall we talked at some point about having a config setting that runs Plotly.validate during supplyDefaults or something, kind of a debug mode - is there an issue for this? @mdamien is right of course that this kind of error is tough to catch, but that's true of every attribute really, they'll all silently ignore invalid input.

@etpinard
Copy link
Contributor

I seem to recall we talked at some point about having a config setting that runs Plotly.validate during supplyDefaults or something, kind of a debug mode - is there an issue for this?

Here' it is ➡️ #1741

@etpinard etpinard closed this May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants