Fixing the non-fancy scattergl 'single data point' infinite loop #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monfera looks good! Wanna add a test for it in https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/gl2d_scatterplot_contour_test.js ? |
|
@etpinard absolutely! Planning to do so over the weekend. |
monfera
changed the title
|
@etpinard I ended up putting the single-point case into a preexisting image test, because both the fixed calculation edge case and (potential) rendering edge cases can be detected this way. For example, the |
|
Beautifully done. Thanks very much @monfera !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purports to fix #1164