Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click on "scattergl" plot makes panning option not to work properly #744

Closed
ifll opened this issue Jul 14, 2016 · 5 comments · Fixed by #958
Closed

Double click on "scattergl" plot makes panning option not to work properly #744

ifll opened this issue Jul 14, 2016 · 5 comments · Fixed by #958
Labels
bug something broken
Milestone

Comments

@ifll
Copy link

ifll commented Jul 14, 2016

When clicking the panning option of the menubar of the plot it is possible to pan the plot. Once you doubleclick the plot, the panning option is still available but the panning range is rescricted to a small distance, which makes that for covering a large paning you have to click -> pan -> click again -> pan again -> click again....

Clicking again the panning option of the menubar resets the panning and it is available to pan normally again.

It is possible to reproduce this problem here:
http://codepen.io/etpinard/pen/XXrzBe

@etpinard
Copy link
Contributor

Part of the known gl2d limitations #130

@etpinard etpinard added this to the On-par gl2d milestone Jul 14, 2016
@etpinard etpinard added the bug something broken label Jul 14, 2016
@etpinard
Copy link
Contributor

@dfcreative might be interested in this issue too ...

@dy
Copy link
Contributor

dy commented Sep 16, 2016

That seems to be a CSS issue — some element becomes draggable in some reason.
If we add

.gl-container {
    @include vendor('user-select', none);
}

to _base.scss and rebuild the package, the problem gets fixed, I am not sure though if there are possible use-cases where user may want to actually select something on the plot. For scattergl there is nothing to select, but mb other plot types create some selectable selement in .gl-container.

@etpinard
Copy link
Contributor

@dfcreative great. Thanks for looking into this.

The<div gl-container> is used for gl3d and mapbox-gl plots also. So we should make sure that adding that user-select-none class doesn't affect them.

Perhaps we could add the user-select-none class to the gl2d canvas instead to make sure to not affect other plot types.

etpinard added a commit that referenced this issue Sep 21, 2016
- this sanitizes double clicks interactions
- e.g. double-click on the canvas now no longer puts
  the select-box in a weird state
- see #744 for more info
@monfera
Copy link
Contributor

monfera commented Sep 30, 2016

@dfcreative @etpinard nice solution, thx for referencing URL in the scene2d code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants