Skip to content

Commit

Permalink
Merge pull request #6517 from plotly/is-mobile-v4
Browse files Browse the repository at this point in the history
Fix feature detection for Samsung browser on desktop
  • Loading branch information
archmoj authored Mar 11, 2023
2 parents a8631b8 + b565395 commit 9a4e88b
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 19 deletions.
1 change: 1 addition & 0 deletions draftlogs/6517_fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix feature detection for Samsung browser on desktop [[#6517](https://github.com/plotly/plotly.js/pull/6517)]
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"glslify": "^7.1.1",
"has-hover": "^1.0.1",
"has-passive-events": "^1.0.0",
"is-mobile": "^3.1.1",
"is-mobile": "^4.0.0",
"mapbox-gl": "1.10.1",
"mouse-change": "^1.4.0",
"mouse-event-offset": "^3.0.2",
Expand Down
2 changes: 1 addition & 1 deletion stackgl_modules/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1819,7 +1819,7 @@ function BufferBigIntNotDefined() {
module.exports = isMobile;
module.exports.isMobile = isMobile;
module.exports["default"] = isMobile;
var mobileRE = /(android|bb\d+|meego).+mobile|armv7l|avantgo|bada\/|blackberry|blazer|compal|elaine|fennec|hiptop|iemobile|ip(hone|od)|iris|kindle|lge |maemo|midp|mmp|mobile.+firefox|netfront|opera m(ob|in)i|palm( os)?|phone|p(ixi|re)\/|plucker|pocket|psp|series[46]0|samsungbrowser|symbian|treo|up\.(browser|link)|vodafone|wap|windows (ce|phone)|xda|xiino/i;
var mobileRE = /(android|bb\d+|meego).+mobile|armv7l|avantgo|bada\/|blackberry|blazer|compal|elaine|fennec|hiptop|iemobile|ip(hone|od)|iris|kindle|lge |maemo|midp|mmp|mobile.+firefox|netfront|opera m(ob|in)i|palm( os)?|phone|p(ixi|re)\/|plucker|pocket|psp|series[46]0|samsungbrowser.*mobile|symbian|treo|up\.(browser|link)|vodafone|wap|windows (ce|phone)|xda|xiino/i;
var notMobileRE = /CrOS/;
var tabletRE = /android|ipad|playbook|silk/i;
function isMobile(opts) {
Expand Down
18 changes: 9 additions & 9 deletions stackgl_modules/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion stackgl_modules/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"gl-surface3d": "^1.6.0",
"glslify": "^7.1.1",
"incremental-convex-hull": "plotly/incremental-convex-hull#v1.1.0",
"is-mobile": "^3.1.1",
"is-mobile": "^4.0.0",
"matrix-camera-controller": "^2.1.4",
"ndarray": "plotly/ndarray#v1.1.0",
"ndarray-extract-contour": "plotly/ndarray-extract-contour#v1.1.0",
Expand Down

0 comments on commit 9a4e88b

Please sign in to comment.