subplot(): avoid Reduce() when merging lists #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use do.call() instead to avoid quadratic complexity of growing lists
ignore NULL values
jcheng5
approved these changes
May 28, 2019
jcheng5
reviewed
May 28, 2019
| p$attrs <- Reduce(c, lapply(plots, "[[", "attrs")) | ||
| p$layout <- modify_list(p$layout, Reduce(modify_list, layouts)) | ||
| p$attrs <- unlist(lapply(plots, "[[", "attrs"), recursive = FALSE) | ||
| p$layout <- Reduce(modify_list, layouts, p$layout) |
There was a problem hiding this comment.
If there are a lot of layouts then do.call(modify_list, c(list(p$layout), layouts)) might be better (or something like that with judicious quote() calls added--@wch can give you details if you choose to go the do.call route). If there aren't a lot of layouts then this is fine with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR replaces the uses of
Reduce(c, ...)to merge the lists withunlist(..., recursive = FALSE).The motivation: for the list
xof n elementsReduce(c, x)would implicitly create n lists/vectors of lengths 1 to n, whereas only the last one is needed. The pattern adds a considerable overhead when the subplots contain a lot of data.It also simplifies
ensure_one(): instead of using[to get the one-element list, it uses[[to get this one element (nulls are automatically filtered out).