-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump plotly.js version #1178
Bump plotly.js version #1178
Conversation
Two more small issues with this PR (they might automatically get fixed when you fix the bigger selection issue)
|
@daattali thanks, I've reported a minimal example here -- plotly/plotly.js#2282 |
perhaps it'd be more elegant to have opacityDim map to unselected.marker.opacity?
…selected attribute also cleans up some old/messy code
@daattali re-installing this PR should fix at least your 2nd point, let me know if you find anything else! |
Thanks. I'll take your word for it, I'll test it out when PR is ready/merged |
@daattali thanks, that's odd that the positions change (I wasn't able to replicate that bit), but there does indeed seem to be a problem with Plotly.addTraces() that could explain the lack of color change -- plotly/plotly.js#2298 |
Try the app that you helped me work on. When I install plotly from 5e4da51 it works perfectly fine, when I install plotly from today, selection is messed up |
Things that need to be done before we can safely update:
selected
attribute/api with crosstalk framework.unselected
attribute/api with crosstalk framework (shouldopacityDim
map tounselected.marker.opacity
, etc?).(UPDATE: I can't think of a good use-case for changing stuff like
marker.color
,marker.size
, ortextfont.color
for unselected marks, and in fact, I think it just leads to more confusion than usefulness, so I'm not likely going to add integration)plotly_selected
)selectedpoints
to set an initial crosstalk selection (likedefaultValues
arg inhighlight()
)?(UPDATE: It's definitely not straight-forward how one would use
selectedpoints
in conjunction with crosstalk, and adding support wouldn't enable anything that can't already be done viadefaultValues
inhighlight()
, so I'm not sure the dev time this would require is necessarily worth it)