plotly.js fix bug when crosstalk filter keys are null

plotly · Apr 23, 2022 · f72277e · f72277e
1 parent e6cc271
commit f72277e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -11,6 +11,7 @@
 * `ggplotly()` now correctly handles `geom_tile()` with no `fill` aesthetic. (#2063)
 * `ggplotly()` now respects `guide(aes = "none")` (e.g., `guide(fill = "none")`) when constructing legend entries. (#2067)
 * Fixed an issue with translating `GGally::ggcorr()` via `ggplotly()`. (#2012)
+* Fixed an issue where clearing a crosstalk filter would raise an error in the JS console (#2087)
 
 ## Improvements
 

diff --git a/inst/htmlwidgets/plotly.js b/inst/htmlwidgets/plotly.js
@@ -616,9 +616,9 @@ TraceManager.prototype.updateFilter = function(group, keys) {
         traces.push(trace);
       }
     }
+    this.gd.data = traces;
   }
 
-  this.gd.data = traces;
   Plotly.redraw(this.gd);
 
   // NOTE: we purposely do _not_ restore selection(s), since on filter,