Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation fault when NODE_OPTIONS environment variable set #124

Closed
jonmmease opened this issue Aug 29, 2018 · 0 comments · Fixed by #266
Closed

Segmentation fault when NODE_OPTIONS environment variable set #124

jonmmease opened this issue Aug 29, 2018 · 0 comments · Fixed by #266
Labels
type: bug

Comments

@jonmmease
Copy link
Contributor

See Electron issue electron/electron#12695

Prior to electron version 2.0.3., having the NODE_OPTIONS environment variable set causes electron applications to exit with a segmentation fault, and I can reproduce this behavior with orca.

This is particularly unfortunate for plotly.py because the instructions for installing the plotly.py JupyterLab extensions require setting NODE_OPTIONS=--max-old-space-size=4096 to avoid out-of-memory errors.

See #89 for @etpinard's notes on Electron 2.0. It think I'll try out 2.0.3+ today and see if anything breaks. It would be nice to make this change before the plotly.py 3.2.0 release if it's not too large of an effort.
jonmmease added a commit that referenced this issue Aug 29, 2018
@jonmmease
Update electron version to 2.0.8 to address segmentation fault
8ce5243 
See #124
@jonmmease jonmmease mentioned this issue Aug 29, 2018
Closed
jonmmease added a commit to plotly/plotly.py that referenced this issue Aug 29, 2018
@jonmmease
Workaround for plotly/orca#124
096fb57 
Unset the NODE_OPTIONS environment variable before calling orca
to avoid an orca segmentation fault
@jonmmease jonmmease mentioned this issue Aug 29, 2018
Merged
jonmmease added a commit to plotly/plotly.py that referenced this issue Aug 30, 2018
@jonmmease
Add workaround for orca segmentation fault (#1140)
f6bbdae 
* Workaround for plotly/orca#124

Unset the NODE_OPTIONS environment variable before calling orca
to avoid an orca segmentation fault

* Constrain ipykernel version. Build was breaking on Python 2.7 with ipykernel 4.9

* Reconnect stream write on 502 errors

Example test failure:
```
======================================================================
ERROR: test_stream_single_points (plotly.tests.test_plot_ly.test_stream.test_stream.TestStreaming)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/project/plotly/tests/test_plot_ly/test_stream/test_stream.py", line 52, in test_stream_single_points
    my_stream.write(Scatter(x=[1], y=[10]))
  File "/home/circleci/project/plotly/plotly/plotly.py", line 704, in write
    self._stream.write(jdata, reconnect_on=reconnect_on)
  File "/home/circleci/project/plotly/plotly/chunked_requests/chunked_request.py", line 61, in write
    msg=response.read()))
Exception: Server responded with status code: 502
and message: <html><body><h1>502 Bad Gateway</h1>
The server returned an invalid or incomplete response.
</body></html>
```
@jonmmease jonmmease mentioned this issue Dec 3, 2018
Closed
@antoinerg antoinerg mentioned this issue Jul 3, 2019
Closed
@antoinerg antoinerg mentioned this issue Nov 12, 2019
Merged
5 tasks
@antoinerg antoinerg mentioned this issue Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump electron to 6.1.4 plotly/orca
2 participants
@etpinard @jonmmease