Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements wheelSensitivity feature #97 #150

Closed
wants to merge 2 commits into from

Conversation

kinimesi
Copy link
Contributor

@kinimesi kinimesi commented Aug 19, 2021

About

Description of changes

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

Closes #[issue number]

Other comments

Copy link

@xhluca xhluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey can you add an example inside demos?

And update the docs if this is something relevant to talk about beyond it's obvious use?

Also it'd be nice to have tests for this, but if it's too difficult and you want to wait until after the tests are rewritten, feel free to open and issue and track it

@kinimesi
Copy link
Contributor Author

This feature is exposes wheelSensitivity option which is one of the initialization parameters of the Cytoscape.js. This is very similar to the other initialization parameters that dash-cytoscape already has such as zoom, minZoom, userZoomingEnabled and etc. We do not have tests or demos for such features. I don't think that one is necessary for wheelSensitivity either.

It's very obvious to use and one line description was added to the relevant files in the PR (all other similar options also have one line descriptions).

@alimanfoo
Copy link

Just to mention I'd very much like this feature. Is there any reason why this PR got stalled?

@ivolake
Copy link

ivolake commented Dec 14, 2023

I await this functionality with the greatest anticipation.

@alexcjohnson
Copy link
Collaborator

Done in #203

@alexcjohnson alexcjohnson deleted the wheel-sensitivity-feature branch January 26, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants