-
-
Notifications
You must be signed in to change notification settings - Fork 144
Conversation
@@ -2,7 +2,7 @@ node_modules/ | |||
.npm | |||
.git/ | |||
vv/ | |||
venv/ | |||
venv* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use venv36 for testing on python 3 and venv for python 2, was doing a release the other time and noticed the package was over 130mb because it took the venv36 files, that package was canceled before upload.
@valentijnnieman please review. There's 13 visuals diffs, I think an icon got added in the graph ? |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "dash-core-components", | |||
"version": "0.35.2", | |||
"version": "0.35.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to do minor version updates (e.g. to 0.36.0
) since from the users perspective, this version update adds many new features to the dcc.Graph
component.
ad3118c
to
20fdfd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 if the changelog is updated! And yeah, it looks like a new icon was added to plotly.js.
- Updated plotly.js to 1.42.1 [#354](https://github.com/plotly/dash-core-components/pull/354) | ||
- https://github.com/plotly/plotly.js/releases/tag/v1.42.0 | ||
- https://github.com/plotly/plotly.js/releases/tag/v1.42.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually copy over the changelog from plotly.js here, check out other updates that included plotly.js releases below, it should look similar to that.
another bug fix release: https://github.com/plotly/plotly.js/releases/tag/v1.42.2 |
I made sure the local file and external file are the same by doing
wget https://cdn.plot.ly/plotly-1.42.1.min.js
for the local file.