Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Add current date's initial visible month #201

Closed
wants to merge 1 commit into from
Closed

Conversation

xblad
Copy link

@xblad xblad commented May 16, 2018

Added current date as the last resort for the initialVisibleMonth property of the component in DatePickerRange.react.js and in DatePickerSingle.react.js (issue #115)

@chriddyp
Copy link
Member

Thanks! This looks good to me. A few other things would be helpful:

  • Would you mind adding a test? We can just render the component and then take a screenshot of the new behaviour.
  • Would you mind updating the CHANGELOG.md and the version numbers in version.py and package.json?

Added current date as the last resort for the initialVisibleMonth property of the component in DatePickerRange.react.js and in DatePickerSingle.react.js (issue plotly#115)
@xblad
Copy link
Author

xblad commented May 22, 2018

@chriddyp, I have added the tests and updated version number (v0.22.3 + tag) and GHANGELOG.md.
Nevertheless, it is my first contribution on Github, so quick revision of the changes is highly appreciated 😃
Btw, I see, that percy/dash-core-components test was failed, but I don't have an access to the resource, so I'm not able to check why...

@valentijnnieman
Copy link
Contributor

@chriddyp This seems solid - can we update & merge this? 💃

@mikesmith1611
Copy link

It looks like change has been implemented:
https://dash.plot.ly/dash-core-components/datepickersingle
can confirm it works

@valentijnnieman
Copy link
Contributor

@xblad Hi! Sorry that it took so long, this should've been merged already! There are now some merge conflicts though - would you be able to solve them? If so, I can help you with rebuilding the package. Alternatively, I could fix the merge conflicts myself, but I would have to create a separate PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants