Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resizing plot feature and created tests for this feature. #579

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

nickmelnikov82
Copy link
Member

@nickmelnikov82 nickmelnikov82 commented Sep 28, 2021

Closes #545

About

I am adding a feature to an existing component.

Description of changes

Create a new feature.
I added height and width properties to the NeedlePlot component and fragment. In the NeedlePlot component, I add height and width properties as well set them. In the NeedlePlot component, I gave the div and plot component these properties.
Also, I created tests for checking that these properties work as expected.

Copy link
Contributor

@HammadTheOne HammadTheOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@HammadTheOne HammadTheOne merged commit 2178760 into master Oct 1, 2021
@HammadTheOne HammadTheOne deleted the size-feature branch October 1, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing needle plot
2 participants