Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forna console log #438

Merged
merged 7 commits into from
Nov 18, 2019
Merged

Fix forna console log #438

merged 7 commits into from
Nov 18, 2019

Conversation

shammamah-zz
Copy link
Contributor

About

  • Removed the console.log calls that were used to print the positions of each nucleotide in the sequence. (see plotly/fornac@aa9ff38)

@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-438 November 8, 2019 21:39 Inactive
alexcjohnson
alexcjohnson approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🙈 💃

@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-438 November 18, 2019 17:30 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-438 November 18, 2019 17:36 Inactive
@shammamah-zz shammamah-zz merged commit b32639d into master Nov 18, 2019
@shammamah-zz shammamah-zz deleted the fix-forna-console-log branch November 18, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@Marc-Andre-Rivet Marc-Andre-Rivet Awaiting requested review from Marc-Andre-Rivet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shammamah-zz @alexcjohnson