-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show working copy links based on backend actions #6393
Conversation
✅ Deploy Preview for plone-components canceled.
|
9974e13
to
b5f0d56
Compare
b5f0d56
to
e9982fa
Compare
Co-authored-by: Piero Nicolli <[email protected]>
…lto config setting
@plone/volto-team I think this change can be reviewed and merged independently from the other PRs related to supporting working copies for the Plone site. It's updating the logic for when Volto displays the checkin/checkout actions in the More menu, so that it's based on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a more appropriate admonition of versionremoved
, not deprecated
. Otherwise some minor wording and style fixes. I'll commit them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs LGTM now. I'll double-check the PR preview build.
I lied. There is a build error in RTD that appears to be this recently reported issue, and a release is pending. Something for y'all to watch out for in your builds. See the build log for error message. |
We can ignore the failing readme linkcheck. https://2021.ploneconf.org/ is not returning a 500 ISE, although this is not the first time it has done so. |
…king copy documentation for details.
I checked out this PR, built the docs, and made one more change. The docs look good now. |
@davisagli would it be good to remove |
@wesleybl Not necessarily... I merged the PRs for plone.app.iterate and plone.restapi this morning, so this is the remaining one to finish that issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the technical side of this PR. But I tried it out and it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -259,7 +259,7 @@ working-copy-acceptance-backend-start: ## Start backend acceptance server for wo | |||
|
|||
.PHONY: working-copy-acceptance-frontend-prod-start | |||
working-copy-acceptance-frontend-prod-start: build-deps ## Start acceptance frontend in production mode for working copy tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could unify this into the main tests then, but it does not hurt to have them separated.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #5284