Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show working copy links based on backend actions #6393

Merged
merged 11 commits into from
Jan 29, 2025
Merged

Conversation

wesleybl
Copy link
Member

@wesleybl wesleybl commented Oct 10, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #5284

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 0ad8e66
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67988f42bebcf30008f24f7d

@wesleybl wesleybl force-pushed the working_copy_portal branch from b5f0d56 to e9982fa Compare December 17, 2024 21:06
@davisagli
Copy link
Member

@plone/volto-team I think this change can be reviewed and merged independently from the other PRs related to supporting working copies for the Plone site. It's updating the logic for when Volto displays the checkin/checkout actions in the More menu, so that it's based on the @actions endpoint.

@davisagli davisagli requested a review from stevepiercy January 28, 2025 00:12
@davisagli davisagli changed the title Shows working copy options for Plone Site Show working copy links based on backend actions Jan 28, 2025
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more appropriate admonition of versionremoved, not deprecated. Otherwise some minor wording and style fixes. I'll commit them.

docs/source/configuration/settings-reference.md Outdated Show resolved Hide resolved
docs/source/configuration/settings-reference.md Outdated Show resolved Hide resolved
docs/source/configuration/settings-reference.md Outdated Show resolved Hide resolved
docs/source/configuration/workingcopy.md Outdated Show resolved Hide resolved
docs/source/configuration/workingcopy.md Outdated Show resolved Hide resolved
docs/source/configuration/workingcopy.md Outdated Show resolved Hide resolved
docs/source/configuration/settings-reference.md Outdated Show resolved Hide resolved
docs/source/configuration/workingcopy.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM now. I'll double-check the PR preview build.

@stevepiercy
Copy link
Collaborator

I lied. There is a build error in RTD that appears to be this recently reported issue, and a release is pending. Something for y'all to watch out for in your builds.

nodejs/corepack#612

See the build log for error message.

https://app.readthedocs.org/projects/volto/builds/26990887/

@stevepiercy
Copy link
Collaborator

We can ignore the failing readme linkcheck. https://2021.ploneconf.org/ is not returning a 500 ISE, although this is not the first time it has done so.

@stevepiercy
Copy link
Collaborator

I checked out this PR, built the docs, and made one more change. The docs look good now.

@sneridagh sneridagh requested a review from a team January 28, 2025 10:47
@wesleybl
Copy link
Member Author

@plone/volto-team I think this change can be reviewed and merged independently from the other PRs related to supporting working copies for the Plone site. It's updating the logic for when Volto displays the checkin/checkout actions in the More menu, so that it's based on the @actions endpoint.

@davisagli would it be good to remove Closed #5284 from the issue description?

@davisagli
Copy link
Member

@wesleybl Not necessarily... I merged the PRs for plone.app.iterate and plone.restapi this morning, so this is the remaining one to finish that issue.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the technical side of this PR. But I tried it out and it works.

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -259,7 +259,7 @@ working-copy-acceptance-backend-start: ## Start backend acceptance server for wo

.PHONY: working-copy-acceptance-frontend-prod-start
working-copy-acceptance-frontend-prod-start: build-deps ## Start acceptance frontend in production mode for working copy tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could unify this into the main tests then, but it does not hurt to have them separated.

@sneridagh sneridagh merged commit 12c187a into main Jan 29, 2025
78 of 79 checks passed
@sneridagh sneridagh deleted the working_copy_portal branch January 29, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Working copy for Plone Site
6 participants