No Label for Search Block Dropdown Form element

[ThomasKindermann]

Describe the bug
The "sort by" dropdown in the Search block doesn't have a label.
It should have a label for A11y.

To Reproduce
Steps to reproduce the behavior:

1. Go to any volto page
2. Create a Page with the Search block.
3. Use an A11y Tool or inspect the Dropdown
4. Dropdown / Input Form element does not have a label.

Expected behavior
Any Form Elements should have a label for screen readers.

Screenshots

• OS: OSX
• Browser Chrome
• Volto 17.0.0-alpha.24
• Plone 6.0.6
• plone.restapi 8.41.0

[pranayjoshi]

Hi @ThomasKindermann , I am working on this. Is 'Sort by Dropdown' fine as a label? or shall I use the dropdown value as the label?

[stevepiercy]

In English the phrase preceding the sort input should be Sort by, not Sort on. I hate to pile on to an issue, but since it is part of the same block, it may as well be corrected at the same time. I do not suggest refactoring the code to replace sortOn* names, as I don't know what impact that would have and going that far might be a breaking change.

For the sort input, I would suggest the label Sort by selected option. I thought about just selected option, but I doubt that screen readers would be able to connect the text before the input to the actual input.

The label for the sort input must be internationalized. See https://6.docs.plone.org/volto/recipes/i18n.html.