Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote version strings in YAML #492

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Quote version strings in YAML #492

merged 1 commit into from
Feb 12, 2018

Conversation

thet
Copy link
Member

@thet thet commented Feb 8, 2018

See: travis-ci/docs-travis-ci-com#1540

Brought to my attention by this PR: collective/icalendar#249

@thet thet requested a review from tisto February 8, 2018 21:56
@coveralls
Copy link

coveralls commented Feb 8, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.758% when pulling 3079494 on thet-yamlversionstrings into 2429162 on master.

@tisto
Copy link
Member

tisto commented Feb 11, 2018

@thet thanks for the fix! Though, I usually tend to not mention non-code related fixes in the changelog.

@thet thet force-pushed the thet-yamlversionstrings branch from 86531b1 to 3079494 Compare February 12, 2018 08:22
@thet
Copy link
Member Author

thet commented Feb 12, 2018

Agreed, update done.

@tisto tisto merged commit 40cd629 into master Feb 12, 2018
@tisto tisto deleted the thet-yamlversionstrings branch February 12, 2018 10:53
@tisto
Copy link
Member

tisto commented Feb 12, 2018

@thet thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisto tisto Awaiting requested review from tisto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thet @coveralls @tisto