-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes on how to install addon packages in an extended container. #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A required minor syntax fix, and an optional suggestion.
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Fixed. Please merge at your leisure. Thanks. |
All addressed. |
@stevepiercy tests aren't running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntax fixes.
Yeah, looks like someone with the GitHub username/password is required, or at least someone more familiar than I with how to successfully run this step in the GitHub Action. https://github.com/plone/plone-backend/actions/runs/3170285071/jobs/5162771257 |
@Rudd-O Can you submit a PR from a branch within the plone/plone-backend repository, instead of from your fork? Then the tests should be able to run. From your perspective, this would mean adding [email protected]:plone/plone-backend.git as a git remote, pushing the branch there, and then opening a PR from that branch. You should have access to do this if you've already signed the Plone contributer agreement. |
Oh, I had a problem recently in PyCharm pushing to one or two Plone repos recently. I had to purge all GitHub entries in my macOS Keychain, reauthorize, and then I was able to push. |
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Do we need to run the tests to commit this? This is turning into a lot of work just to update a README. |
imo, all documentation should go to |
I agree. I looked at this entire README for the first time just now. It does not make sense to maintain duplicate information in two places, the other being at https://6.dev-docs.plone.org/install/containers/index.html and its related files. Sorry for not noticing sooner. On the plus side, contributing to Plone 6 Documentation is much easier. Unless there is a very good reason not to do the following, let's move any content from this README into Plone 6 docs, and replace it with a link to them. The only thing that might be a concern is Plone 5 support and getting that into the Plone 5 docs, which is not simple or easy. What do y'all think 🤔 ? |
README here should have only information about the latest versions (and this is taken care on the 5.2.x branch). |
I created #80 so we don't forget, and to track it in the Plone 6 Docs release GitHub project. |
No description provided.