Index comments on solr #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an object had queued a partial and a full reindex, despite the comment, it was always wining the partial reindexing. And as indexes is a list, make sure on a full reindex None is given.
ale-rt
approved these changes
Mar 21, 2019
|
The changes in collective.solr got reverted, thus this PR here is pointless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After collective/collective.solr#102 got merged, one still needs plone/plone.app.discussion#152 and this one here to get comments being indexed.
@ale-rt @gyst would you mind giving a review? I'm a bit git freak 😅, I do like to keep commits clean and well sorted (one builds on top of the previous one), so if you rather than reviewing this pull request via github you do locally commit by commit you will get a better picture 👍
One other thing that might interest you is that now, with these changes (nothing is released so far) comments will be always indexed, maybe a setting to control that would be needed for your use cases? 🤔 I'm happy to implement that if there is agreement on the way forward.