-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some translations don't get picked up in editor modals #3120
Comments
I'm looking with current 5.2 branch (future 5.2.2) For insert a link:
For insert an image:
|
Is there an issue with "Format" menu in the toolbar too? In French it's the same "Format". In German shouldn't it be "Formate"? |
@djowett-ftw You added the messages "Select an anchor" and "Target" in |
Yeah I don't think this is correctly internationalized, I think it should be variables there and you need to have the variable in the object https://github.com/plone/mockup/blob/3e64876363286d9f1dd8d7a97a18ed013479bbe3/mockup/patterns/tinymce/js/links.js#L463 returned by |
I resynced widgets.pot and kept manually your two messages for now. This added two messages related to image caption, so if you translate them, this should fixes the translation in the UI for those.
|
@vincentfretin I did the internationalization work in https://github.com/plone/mockup/pull/930/files#diff-ae0bd47fbe86e225ca9bc31a278348eeL66. It was a backport to begin with at least, but maybe it ended up with fixes that aren't in Plone 5.2 (e.g. making "Target" translatable and reverting "Remove Link(s)" to "Remove Link" - as there are no translations for the former. |
Ah! For Plone 5.1.x, we use mockup branch 2.7.x and for Plone 5.2.x we use mockup master. |
For the "object Object:" tab, it should be "Upload". This is working properly on buildout.coredev 5.1 / mockup 2.7.x. The regression is in mockup master. |
I did a fix for the Upload tab in TinyMCE Image showing [object Object] |
I updated my comment #3120 (comment) to create a todo list of the remaining points. |
Hi @vincentfretin, sorry I've not been granted time to work on this - I think I burned too much time on the original 5.1 patch (with the confusions you encountered) to get favour for any more :-( |
I fixed the remaining issues in plone/mockup@ad2773a |
BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
What I did:
Use demo.plone.org in German
Try to add a link or an image
What I expect to happen:
Modals are fully translated in the selected language (German)
What actually happened:
Some translations don't get picked up
What version of Plone/ Addons I am using:
5.2.1 on demo.plone.org (also the case in 5.1.6 where we are using it)
The text was updated successfully, but these errors were encountered: