-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow more customisation to how encodings are included in source issues #196
Comments
I love the idea of the encodings being more readable, and giving users a chance to customize those. Leaving this decision for @wilkyr31d |
@galargh with your approach, do you think it would work fine like this:
@whizzzkid @juliaxbow what do you two think of this feature request? |
I'm not sure I quite understand this algorithm. Could you add an example maybe? |
@galargh I have since added support for github tasklists, so that provides another solution for defining children, but the description parsing still needs some love. The code for parsing children is at
Apparently, description parsing wasn't done already, so i'm adding it as a part of #120, and my algorithm is going to be something like this for description:
steps 1-2 are basically covered at Lines 32 to 40 in e26da1f
Using the basic algorithm above, you could format a description like so and it should work (I'll add a test for this): <!-- description:
My milestone description
thing1
thing2
--> Ideally, descriptions should be renderable. We don't want users to have to maintain two lists of descriptions, so the following should also work. edge-case<!-- description: -->
My milestone description
thing1
thing2
Some other thing that's not considered part of the description Some questions based on the above:
|
It'd be cool if we could customise how encodings are presented in source issues.
E.g. for
testground
, I think the issue (testground/testground#1491) would look better if we could putchildren:
anddescription:
encodings in headers asDescription
andChildren
respectively. As in:Even better if we had full control over the encodings' text. Maybe we could achieve that by allowing the encodings to be hidden inside comments? As in:
The text was updated successfully, but these errors were encountered: