-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Create a view that is "list" instead of "map" #120
Comments
Including some rough mockups below for how this could look. Let me know which direction is preferred and we can go from there. Some addt'l questions:
|
I also like option 1 better! |
I also think working on the list view is a more impactful short term win. we can debug specific css positioning changes after landing this. |
We may have to handle multiple items under the same date. Any ideas on how we would display that? An idea using the FVM example as inspiration would be to show them under an indented list (like Milestone 2.1 there) and have the date be the header. |
@AlexxNica I like that approach, we can fine-tune as we get feedback, but that sounds more than reasonable for now. Are you working on the list view? You mentioned, via slack, having put some effort toward that. I'm planning to take that on as core work tomorrow and finish within a week or so. lmk |
@SgtPooki I started exploring. I'll add that to a branch in my fork and ping you; hopefully that saves you some time. I can also help review the PR when it comes in. Sounds good? |
thanks Alex! |
Here's the template: https://codepen.io/AlexxNica/pen/gOdwxwa I think the template can be a starting point (that's how I prototyped the list view before), but there are definitely other ways to achieve the same, so feel free to choose whatever method you're most comfortable with! @SgtPooki let me know if it'd be helpful to pair up for some time next week to do this together. 🙌 |
Thanks Alexx, that's a great snippet for showing the nesting 👍 got the basic view done for now. working on styling the titles and such before I hop into nesting: just using a simple grid and template areas for the items at this point templateAreas={`"date icon title"
"empty line description"`}
gridTemplateRows={'1fr 1fr'}
gridTemplateColumns={'1fr 0.5fr 8fr'} |
I believe the intention with this list view was to render all children, but I don't think that's a great UX, and so the first pass is going to only render the direct children (similar to how overview only shows direct children). This causes a few issues with navigation within the list view. The initial design doesn't give guidance on communicating to users what links are clickable or not, nor whether to differentiate between linkable children or not, so i've been looking over a number of separate ways to communicate this (because all issue titles are currently Blue and look clickable). Display all links as blue, clickable or not (in original mockup from Julia)Pros
Cons
ScreenshotDisplay clickable links as blue, and non-clickable as black.It's how we do it on overview/detailed view Pros
Cons
ScreenshotUse underlinesVery common and accessible; but not "pretty." Out of fashion. Pros
Cons
ScreenshotUse an icon to indicate traversibilityPros
Cons
ScreenshotsArrowLink Icon (front)Link icon (rear)I'm going to go with the link icon in the front for now, but let me know if others have better ideas, comments, questions, or concerns. cc @whizzzkid |
There is also a discussion in #196 (comment) pertaining to parsing of "description:" content from milestones. |
@SgtPooki I like the link icon at the end, reminds me of Reddit. Using ellipses along with that might not be a bad idea either. Also the GitHub issue will be linked, so two links will exist side by side, I can understand the rationale with link icon before and why you like it. Can we also change the link icon from 🔗 to something like this https://icons8.com/icons/set/open-url the former is more related to inserting a link than opening (latter) |
In roadmaps like the FVM roadmap (fvm.filecoin.io) it is useful to see a single webpage where you can view the linear milestones top to bottom (including the description in prose).
The text was updated successfully, but these errors were encountered: