Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing explicitly set SDKROOT from targets in project. #43

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

jdhealy
Copy link
Contributor

@jdhealy jdhealy commented Oct 25, 2016

Fixes #42.

Carthage would always attempt to find the built framework in a location based off the explicitly set SDKROOT=iphoneos.

Fixes linkedin/ConsistencyManager#42.
@plivesey
Copy link
Owner

YES! I was just trying to debug this, and not getting that far.
Thanks a lot.

@plivesey
Copy link
Owner

I need to rerelease both RocketData and ConsistencyManager to get this update right?

@plivesey plivesey merged commit ef7ef01 into plivesey:master Oct 25, 2016
@jdhealy
Copy link
Contributor Author

jdhealy commented Oct 25, 2016

Well, RocketData's Cartfile doesn't actually specify a version, but I'd advocate for fixing that. You could either tag a new version of ConsistencyManager or add the commit SHA to RocketData's Cartfile and maybe a note for Carthage users in this project's README…

@plivesey
Copy link
Owner

Could you comment on plivesey/RocketData#43 to make sure I have this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants