Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved photo playback/slideshow #252

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

pannal
Copy link
Contributor

@pannal pannal commented Sep 9, 2018

GHI (If applicable): #

Description:

Fast pre-loading photo slideshow

  • preloads the current, previous and next items using temporary files
  • takes care of temp file cleanup (holds temporary instances of a maximum of 10 photos and their backgrounds)
  • shows a transition between on changes
  • tries to not show any loading indicators if possible
  • smoothly handles action spam (multiple next requests in quick succession for example)

Checklist:

  • I have based this PR against the develop branch

@pannal
Copy link
Contributor Author

pannal commented Sep 9, 2018

This is actually not very proof-of-concept-y anymore. I'd like to add a setting for the slideshow interval and maybe a resolution setting.

@ruuk ruuk self-requested a review September 26, 2018 20:38
@ruuk ruuk removed their request for review January 20, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant