Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to scala-xml 2.1.0 for all but scala 2.12 #525

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

mrdziuban
Copy link
Contributor

No description provided.

@lightbend-cla-validator

Hi @mrdziuban,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@tototoshi
Copy link
Member

Related to #526

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I think there was no reason why I kept scala-xml at 1.x when using 2.13.
I also checked other libraries and I think we are fine here.

@mkurz mkurz merged commit f16b621 into playframework:main Jul 6, 2022
@mrdziuban mrdziuban deleted the scala-xml-v2 branch July 6, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants