Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call toIndexedSeq explicitly to reduce warnings #487

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Call toIndexedSeq explicitly to reduce warnings #487

merged 1 commit into from
Jan 30, 2022

Conversation

tototoshi
Copy link
Member

To reduce the following warnings.

[warn] /workspace/twirl/compiler/src/main/scala/play/twirl/compiler/TwirlCompiler.scala:71:11: method copyArrayToImmutableIndexedSeq in class LowPriorityImplicits2 is deprecated (since 2.13.0): Implicit conversions from Array to immutable.IndexedSeq are implemented by copying; Use the more efficient non-copying ArraySeq.unsafeWrapArray or an explicit toIndexedSeq call
[warn]       pos <- meta("MATRIX").split('|')
[warn]           ^
[warn] /workspace/twirl/compiler/src/main/scala/play/twirl/compiler/TwirlCompiler.scala:82:11: method copyArrayToImmutableIndexedSeq in class LowPriorityImplicits2 is deprecated (since 2.13.0): Implicit conversions from Array to immutable.IndexedSeq are implemented by copying; Use the more efficient non-copying ArraySeq.unsafeWrapArray or an explicit toIndexedSeq call
[warn]       pos <- meta("LINES").split('|')
[warn]           ^

@mkurz mkurz merged commit f9a5239 into playframework:main Jan 30, 2022
@ihostage ihostage added this to the 1.6.0 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tototoshi @mkurz @ihostage