Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid deprecated java.lang.Class.newInstance #482

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jan 25, 2022

https://app.travis-ci.com/github/playframework/twirl/jobs/554186867#L356

[warn] /home/travis/build/playframework/twirl/parser/src/main/scala/play/twirl/parser/TwirlParser.scala:334:76: method newInstance in class Class is deprecated
[warn]     val ab     = if (provided != null) provided else manifest.runtimeClass.newInstance().asInstanceOf[BufferType]
[warn]                                                                            ^
[info] done compiling

https://app.travis-ci.com/github/playframework/twirl/jobs/554186867#L356

```
[warn] /home/travis/build/playframework/twirl/parser/src/main/scala/play/twirl/parser/TwirlParser.scala:334:76: method newInstance in class Class is deprecated
[warn]     val ab     = if (provided != null) provided else manifest.runtimeClass.newInstance().asInstanceOf[BufferType]
[warn]                                                                            ^
[info] done compiling
```
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkurz mkurz merged commit a6c8e45 into playframework:main Jan 29, 2022
@xuwei-k xuwei-k deleted the patch-1 branch January 29, 2022 22:36
@ihostage ihostage added this to the 1.6.0 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants