Downgrade scala-parser-combinators and scala-xml #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2021
|
add a |
Fantastic idea! |
|
@SethTisue Done! |
SethTisue
approved these changes
Sep 1, 2021
takezoe
added a commit
to scalatra/scalatra
that referenced
this pull request
Sep 25, 2021
takezoe
added a commit
to scalatra/scalatra
that referenced
this pull request
Sep 25, 2021
takezoe
added a commit
to scalatra/scalatra
that referenced
this pull request
Sep 25, 2021
takezoe
added a commit
to scalatra/scalatra
that referenced
this pull request
Sep 25, 2021
takezoe
added a commit
to scalatra/scalatra
that referenced
this pull request
Sep 25, 2021
takezoe
added a commit
to scalatra/scalatra
that referenced
this pull request
Sep 25, 2021
magnolia-k
added a commit
to scalatra/scalatra
that referenced
this pull request
Oct 3, 2021
* Fix CI trigger (#1245) * Downgrade scala-xml in Scala2 following twirl (#1286) playframework/twirl#439 * Release Scalatra 2.8.1 * Exclude scala-xml from json4s-xml (#1288) * Release Scalatra 2.8.2 * Updated README update version 2.7.x -> 2.8.x * Update version file Co-authored-by: Naoki Takezoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twirl is a sbt-plugin. sbt-plugins get published for Scala 2.12.
The 2.12.x scala compiler depends on 1.x versions for both scala-parser-combinators and scala-xml, see https://github.com/scala/scala/blob/2.12.x/versions.properties#L21-L22
If we would use 2.x versions, we would run into annoying dependency conflicts in sbt 1.5+
There is no need to upgrade these versions to 2.x, the only reason would be if we would cross build for Scala 3, but sbt-plugins do not need to be cross build for Scala 3.
See discussion in scala/scala#9743