Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-xml 2.0.0 (was 1.3.0) #424

Merged
merged 6 commits into from
May 31, 2021

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-lang.modules:scala-xml from 1.3.0 to 2.0.0.
GitHub Release Notes - Changelog - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (1.3.0).
You might want to review and update them manually.

README.md
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-xml" } ]

labels: library-update, semver-major, old-version-remains

@mkurz
Copy link
Member

mkurz commented May 30, 2021

@SethTisue Does that mean we have to drop Scala 2.12.x support from twirl (and therefore also from Play), given that only scala-xml 2.0.0 supports Scala 3?

[error] java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error] 	* org.scala-lang.modules:scala-xml_2.12:2.0.0 (early-semver) is selected over 1.0.6
[error] 	    +- com.typesafe.play:twirl-api_2.12:1.5.0+235-fd49c6ee (depends on 2.0.0)
[error] 	    +- org.scala-lang:scala-compiler:2.12.14              (depends on 1.0.6)

@SethTisue
Copy link
Member

SethTisue commented May 30, 2021

scala-compiler makes only very light use of scala-xml, and scala-xml 2.0 is mostly (though not entirely) binary compatible with 1.x, so I suspect it will work fine to just override the dependency to force the use of 2.0. it's worth a try

@mkurz
Copy link
Member

mkurz commented May 31, 2021

@mkurz mkurz force-pushed the update/scala-xml-2.0.0 branch from f603271 to c3be1d7 Compare May 31, 2021 09:31
@mkurz
Copy link
Member

mkurz commented May 31, 2021

@SethTisue I had to add a libraryDependencySchemes fix to every plugins.sbt - is that ok for you?

@mkurz mkurz merged commit 0251485 into playframework:main May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants