Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version bumps and cleanups #393

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 10, 2021

Motivation: I want everything modernized before I take a stab at adding Scala 3 support.

About the Scala.js upgrade, it's true that upgrading to 1.4.0 means users must use 1.4.0 as well, but I checked in with Seb about that recently and he says don't think about it just do it, as he has said a number of times before. It's considered normal in the Scala.js world that in order to upgrade your libraries you may need to be on latest Scala.js first.

@SethTisue SethTisue marked this pull request as ready for review February 10, 2021 03:16
@SethTisue
Copy link
Member Author

OKAY WHO'S AROUND TO MERGE THIS BAD BOY

@mkurz
Copy link
Member

mkurz commented Feb 12, 2021

Scala.js 1.5.0 released already, see #395

@SethTisue
Copy link
Member Author

I've added a commit with a 1.5.0 upgrade.

@SethTisue
Copy link
Member Author

can somebody review/merge this?

Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ignasi35
Copy link
Member

Hi @SethTisue, I'm guessing this changes in scalajs means in the next release of twirl we should bump to 1.6.0 (we're now on 1.5.x).

@ignasi35 ignasi35 merged commit fdd8b1a into playframework:master Feb 22, 2021
@SethTisue
Copy link
Member Author

@ignasi35 I don't think so. I have not seen other libraries doing that.

@SethTisue SethTisue deleted the version-bumps branch February 22, 2021 16:16
@mkurz
Copy link
Member

mkurz commented Feb 22, 2021

Hey, I am currently working on a couple of Play pull requests and I think Play will need a 2.9 release at some point this year anyway. I don't think Play will be able to support upcoming JDK's (in particular Java 17 LTS in September) and probably also Scala 3 in it's 2.8.x branch and at the same time stay binary compatible... So I think it makes sense to think about a Play 2.9 release... then we could include libraries with major releases (twirl, play-json, play-ws,...), drop stuff (Scala 2.12? sbt 0.13 was removed already from the master branch and interplay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants