-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version bumps and cleanups #393
Conversation
825c12e
to
7397a2b
Compare
OKAY WHO'S AROUND TO MERGE THIS BAD BOY |
Scala.js 1.5.0 released already, see #395 |
I've added a commit with a 1.5.0 upgrade. |
can somebody review/merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @SethTisue, I'm guessing this changes in scalajs means in the next release of |
@ignasi35 I don't think so. I have not seen other libraries doing that. |
Hey, I am currently working on a couple of Play pull requests and I think Play will need a 2.9 release at some point this year anyway. I don't think Play will be able to support upcoming JDK's (in particular Java 17 LTS in September) and probably also Scala 3 in it's 2.8.x branch and at the same time stay binary compatible... So I think it makes sense to think about a Play 2.9 release... then we could include libraries with major releases (twirl, play-json, play-ws,...), drop stuff (Scala 2.12? sbt 0.13 was removed already from the master branch and interplay) |
Motivation: I want everything modernized before I take a stab at adding Scala 3 support.
About the Scala.js upgrade, it's true that upgrading to 1.4.0 means users must use 1.4.0 as well, but I checked in with Seb about that recently and he says don't think about it just do it, as he has said a number of times before. It's considered normal in the Scala.js world that in order to upgrade your libraries you may need to be on latest Scala.js first.