Remove the generation date, keep the source relative #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏼 to keep I wonder if |
This way the generated code is consistent between runs, even on different machines (different absolute paths). Refs playframework#209
raboof
force-pushed
the
make-output-reproducible
branch
from
cf4d709 to
3cf190f
Compare
|
Did a quick manual test and this LGTM. |
ignasi35
approved these changes
Oct 26, 2020
This was referenced Feb 16, 2021
|
@Mergifyio backport 1.5.x |
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Feb 20, 2021
Remove the generation date, keep the source relative (bp #378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the generated code is consistent between runs, even
on different machines (different absolute paths).
Refs #209
The tests are green, but I'm not entirely confident about all the machinery, so this probably needs some better testing first. /cc @ignasi35