Fix scalafmt formatting #337
Conversation
|
On #335 is merged, I can rebase here and merge. This is ready for review. |
octonato
force-pushed
the
rgc/fix-validate-code
branch
from
3c7dd84 to
fadf9a2
Compare
|
Rebased with #335. Ready for review and merge |
octonato
force-pushed
the
rgc/fix-validate-code
branch
from
fadf9a2 to
2e63e5b
Compare
| align.preset = true | ||
| danglingParentheses.preset = true |
There was a problem hiding this comment.
just removing some warnings
| @@ -2,4 +2,4 @@ | |||
|
|
|||
| # Copyright (C) Lightbend Inc. <https://www.lightbend.com> | |||
|
|
|||
| sbt ";+validateCode;+mimaReportBinaryIssues" || exit 1 | |||
| sbt "validateCode;+mimaReportBinaryIssues" || exit 1 | |||
There was a problem hiding this comment.
the cross build for validateCode was the issue. This is a command alias.
It was emitting
[warn] Issuing a cross building command, but not all sub projects have the same cross build configuration. This could result in subprojects cross building against Scala versions that they are not compatible with. Try issuing cross building command with tasks instead, since sbt will be able to ensure that cross building is only done using configured project and Scala version combinations that are configured.
and then ignoring the code. We haven't done any formatting for a while in this project.
Builds on top of #335.
For some reason, the formatting is not being applied and the test is still passing. This fix it the formatting for now and can be merged after #335.
I will fix the check in #336 since on that PR I'm touching the build i many places.