Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Travis scripts #291

Closed
wants to merge 3 commits into from
Closed

Fixing Travis scripts #291

wants to merge 3 commits into from

Conversation

octonato
Copy link
Contributor

No description provided.

@dwijnand
Copy link
Member

Don't set -e. Trying to find how to source travis_terminate.

@ignasi35
Copy link
Member

@renatocaval this is only a format away from complete :-)

@octonato
Copy link
Contributor Author

octonato commented Dec 17, 2019

Don't set -e

@dwijnand, can you explain why? That's how we do in most of our builds.

@octonato
Copy link
Contributor Author

If that's the reason http://mywiki.wooledge.org/BashFAQ/105, I still think for our case it's much simpler to use set -e then adding || exit 1 everywhere.

Do you have any other reason for that?

@octonato
Copy link
Contributor Author

Superseded by #293

@octonato octonato closed this Dec 17, 2019
@octonato octonato deleted the fix-travis-scripts branch December 17, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants