Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code #1389

Merged
merged 15 commits into from
Mar 8, 2022
+422 −610
Merged

Cleanup code #1389

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
788650c
use lambdas instead of anonymous classes
aleksandy Feb 17, 2022
55c3332
remove redundant null-checks and simplify check of the substrings
aleksandy Feb 17, 2022
0f1161b
use predefined charset constant instead of its string representation
aleksandy Feb 17, 2022
04a5d06
remove unused imports
aleksandy Feb 17, 2022
a0720a2
use predefined charset constant instead of its string representation
aleksandy Feb 19, 2022
1d24037
replace methods that use single-character strings with equivalent one…
aleksandy Feb 20, 2022
2b8f7b9
use classes instead of its name when check equality
aleksandy Feb 20, 2022
533ea8f
remove unnecessary boxig/unboxing
aleksandy Feb 21, 2022
cd76030
replace usage of the deprecated method
aleksandy Feb 21, 2022
8d67909
iterate by routes entries instead of get route at every iteration
aleksandy Feb 21, 2022
b1cecf5
remove redundant variables
aleksandy Feb 21, 2022
901c23f
replace classic for-loop by foreach-loop
aleksandy Feb 21, 2022
789b4a4
replace calling a few old api methods by the newone from java 8 api
aleksandy Feb 21, 2022
34af862
replace calling a few old api methods by the newone from java 8 api
aleksandy Feb 21, 2022
4688bf9
remove redundant suppression
aleksandy Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replace calling a few old api methods by the newone from java 8 api
@aleksandy
aleksandy committed Feb 22, 2022
commit 34af862718c023b0104fbfabbe2d919680196e45
6 changes: 3 additions & 3 deletions framework/src/play/classloading/ApplicationClasses.java
View file
Original file line number Diff line number Diff line change
@@ -47,9 +47,9 @@ public void clear() {
* @return The ApplicationClass or null
*/
public ApplicationClass getApplicationClass(String name) {
return classes.computeIfAbsent(name, key -> {
VirtualFile javaFile = getJava(name);
return javaFile == null ? null : new ApplicationClass(name, javaFile);
return classes.computeIfAbsent(name, className -> {
VirtualFile javaFile = getJava(className);
return javaFile == null ? null : new ApplicationClass(className, javaFile);
});
}