Detect changed for JNDI datasource which using jndi: prefix #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue also exists in 1.2.x, 1.3.x, and play1 master. Do you have plan to backport this fixed? Or Could I open separate PRs to each branch (I am more than happy to do it)? Since there are not much Glassfish users. And I only use 1.4 |
|
Hi @phongphan ! |
This was referenced Nov 14, 2016
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jndi: prefix was added at #441.
But the
changed()might not be detected when callingonApplicationStartin DBPlugin.java (it will returnfalseif db.url and db.driver is not configured). And the datasource withjndi:prefix will not be initialized and not been added to DB.datasources.