Correctly shade netty-reactive-streams #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, no need to backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
The problem was introduced in 0efba3c were the assumption was made that the latest netty-reactive-streams version 3 needs to be shaded, however turns out that latest asynchttpclient 2.x still depends on netty-reactive-streams 2.x, so the changing the shading rename rule
com.typesafe.netty.**toorg.playframework.netty.**does not make sense and ruines the original shading...With this fix the shading works again (tested locally).
Side note:
Upcoming async-http-client v3 does not depend on
netty-reactive-streamsanymore, so as soon as we upgrade, we can remove the corresponding shading settings:Another side note:
We already had a case were we almost ran into a problem because of the fact that async-http-client depends on netty-reactive-streams, but back then we were lucky that selenium dropped the usage of async-http-client.
play-teststill pulls incom.typesafe.netty:netty-reactive-streamsplayframework#12049So basically with upcoming async-http-client 3 things will improve from itself 😉