Prevent XXE injection when parsing XML #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchantep
reviewed
Oct 11, 2021
| @@ -25,7 +25,7 @@ trait XMLBodyReadables { | |||
| * }}} | |||
| */ | |||
| implicit val readableAsXml: BodyReadable[Elem] = BodyReadable { response => | |||
| xml.XML.load(new InputSource(new ByteArrayInputStream(response.bodyAsBytes.toArray))) | |||
| XML.parser.load(new InputSource(new ByteArrayInputStream(response.bodyAsBytes.toArray))) | |||
There was a problem hiding this comment.
I don't understand how that fix the issue?
There was a problem hiding this comment.
xml.XML.load initializes the default Scala XML parser without security configuration, while XML.parser calls the XML parser defined in https://github.com/playframework/play-ws/blob/main/play-ws-standalone-xml/src/main/scala/play/api/libs/ws/XML.scala. That parser sets a non-default SAX parser that prevents XML injection.
|
@xuwei-k what do you think about this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #488
Purpose
WS API
response.xmlis vulnerable to XXE injection attacks. Tracing the issue it seems to have been introduced a few years ago when the custom XML parser was replaced by a default one without thexercesSaxParserFactory.I have reverted the code to using the custom factory parser.