Updates - Scala 2.13 & Akka 2.6.0-M3 (bp #354) #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
octonato
force-pushed
the
mergify/bp/master/pr-354
branch
from
c13b565 to
1cc3f7f
Compare
octonato
changed the title
octonato
reviewed
Jun 17, 2019
| val cachecontrol = Seq("com.typesafe.play" %% "cachecontrol" % cachecontrolVersion) | ||
|
|
||
| val asyncHttpClientVersion = "2.10.0" | ||
| val asyncHttpClient = Seq("org.asynchttpclient" % "async-http-client" % asyncHttpClientVersion) | ||
|
|
||
| val akkaVersion = "2.6.0-M2" | ||
| val akkaVersion = "2.6.0-M3" |
There was a problem hiding this comment.
in order to have Scala 2.13 support, we must bump the Akka version as well.
Akka 2.6.0-M2 has no binaries for Scala 2.13
octonato
reviewed
Jun 17, 2019
project/Dependencies.scala
Outdated
| Seq("org.scala-lang.modules" %% "scala-xml" % scalaXmlVersion213) | ||
| } else { | ||
| Seq("org.scala-lang.modules" %% "scala-xml" % scalaXmlVersion) | ||
| } |
There was a problem hiding this comment.
I will review this part. Seems like unnecessary
ignasi35
previously approved these changes
Jun 17, 2019
31 tasks
Co-authored-by: Marcos Pereira <[email protected]> Co-authored-by: Doug Roper <[email protected]> (cherry picked from commit 8a0eb3c) (cherry picked from commit 1761b49) (cherry picked from commit 9c27797)
octonato
force-pushed
the
mergify/bp/master/pr-354
branch
from
954bb9b to
522f63f
Compare
ignasi35
approved these changes
Jun 17, 2019
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #354 done by Mergify.io
Cherry-pick of 8a0eb3c has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/